| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Yuqi Gu <Yuqi(dot)Gu(at)arm(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimize Arm64 crc32c implementation in Postgresql |
| Date: | 2018-04-04 08:35:19 |
| Message-ID: | 87542d83-316d-fb56-8b42-85226b9bd404@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/04/18 21:56, Daniel Gustafsson wrote:
> The following line should say SSE and not SSSE (and the same typo is in
> src/include/pg_config.h.in and src/include/pg_config.h.win32). While not
> introduced in this patch, it’s adjacent to the patched codepath and on topic so
> may well be fixed while in there.
>
> AC_DEFINE(USE_SSE42_CRC32C_WITH_RUNTIME_CHECK, 1, [Define to 1 to use Intel SSSE 4.2 CRC instructions with a runtime check.])
I pushed that as a separate commit, as that goes back to 9.5. Also, I
noticed that the description of USE_SLICING_BY_8_CRC32C was completely
wrong, fixed that too. Thanks!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2018-04-04 08:54:14 | Postgres stucks in deadlock detection |
| Previous Message | Kyotaro HORIGUCHI | 2018-04-04 08:26:46 | Re: Problem while setting the fpw with SIGHUP |