Re: [sqlsmith] Crash in GetOldestSnapshot()

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Andreas Seltenreich <seltenreich(at)gmx(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [sqlsmith] Crash in GetOldestSnapshot()
Date: 2016-08-06 12:21:02
Message-ID: 874m6ydrna.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Andreas" == Andreas Seltenreich <seltenreich(at)gmx(dot)de> writes:

418 if (OldestActiveSnapshot != NULL)
419 ActiveLSN = OldestActiveSnapshot->as_snap->lsn;
420
421 if (XLogRecPtrIsInvalid(RegisteredLSN) || RegisteredLSN > ActiveLSN)
422 return OldestActiveSnapshot->as_snap;

This second conditional should clearly be inside the first one...

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-08-06 12:33:47 Re: [sqlsmith] Crash in GetOldestSnapshot()
Previous Message Michael Paquier 2016-08-06 12:05:04 Re: [sqlsmith] Crash in GetOldestSnapshot()