| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Donald Dong <xdong(at)csumb(dot)edu>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net> |
| Subject: | Re: Ryu floating point output patch |
| Date: | 2019-02-17 23:15:42 |
| Message-ID: | 874l92j9dg.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> Here's a patch without docco. How much do we actually want to
>> document this? I'm not sure it has any great value outside of
>> cross-version upgrade testing.
Tom> I think we have to document it, but it can be fairly terse perhaps.
Tom> Use the specified value of extra_float_digits when dumping
Tom> floating-point data, rather than pg_dump's default.
Tom> I don't think we need to go into detail about when/why you might
Tom> want to use it; I can see people thinking of their own reasons.
It should probably at least say that (a) the default is to dump with the
maximum available precision, and at least hint at (b) that ordinary use
doesn't require the option. We shouldn't mislead people into thinking
they need it when they don't.
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2019-02-17 23:21:56 | Re: Ryu floating point output patch |
| Previous Message | Andrew Gierth | 2019-02-17 23:13:54 | Re: Ryu floating point output patch |