Re: log_error_verbosity function display

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: log_error_verbosity function display
Date: 2010-02-11 00:40:20
Message-ID: 8746.1265848820@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Right now, log_error_verbosity displays the source code error location
> in this format:

> LOCATION: parserOpenTable, parse_relation.c:858

> I think it would be clearer to add '()' next to the function name. We
> use '() to display function names in our docs and I think using '()'
> would clarify the output, e.g.:

> LOCATION: parserOpenTable(), parse_relation.c:858

Seems like a waste of log space to me. The convention about writing ()
to decorate function names is hardly universal, and anyway it's mainly
useful to mark things that the reader might not realize are function
names. This can't be anything else.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ragi Y. Burhum 2010-02-11 00:49:59 knngist patch support
Previous Message Bruce Momjian 2010-02-11 00:21:25 Re: psql tab completion for DO blocks