Re: Broken build on macOS (Universal / Intel): cpuid instruction not available

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Jakob Egger <jakob(at)eggerapps(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Bussmann <t(dot)bussmann(at)gmx(dot)net>
Subject: Re: Broken build on macOS (Universal / Intel): cpuid instruction not available
Date: 2026-05-07 16:22:04
Message-ID: 873909.1778170924@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> ... The code in HEAD doesn't have
> that guard, and is essentially assuming that every x86 platform
> wil provide HAVE__GET_CPUID or HAVE__CPUID.

Independently of whether macOS multi-arch is something we consider
supportable, I think the aforesaid assumption is a bad idea.
Can't we make pg_cpuid() return zeroes if it doesn't know how to
get the info, analogously to what pg_cpuid_subleaf() does?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2026-05-07 17:11:28 Re: Fix race condition in XLogLogicalInfo and ProcSignal initialization.
Previous Message Alexander Korotkov 2026-05-07 16:13:33 Re: Fix bug with accessing to temporary tables of other sessions