Re: max_slot_wal_keep_size and wal_keep_segments

From: David Steele <david(at)pgmasters(dot)net>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: max_slot_wal_keep_size and wal_keep_segments
Date: 2020-07-14 11:30:24
Message-ID: 87269252-772e-2daf-9955-674a24e24de6@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/14/20 12:00 AM, Fujii Masao wrote:
>
> The patch was no longer applied cleanly because of recent commit.
> So I updated the patch. Attached.
>
> Barring any objection, I will commit this patch.

This doesn't look right:

+ the <xref linkend="guc-wal-keep-size"/> most recent megabytes
+ WAL files plus one WAL file are

How about:

+ <xref linkend="guc-wal-keep-size"/> megabytes of
+ WAL files plus one WAL file are

Other than that, looks good to me.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-07-14 11:51:27 Re: recovering from "found xmin ... from before relfrozenxid ..."
Previous Message osumi.takamichi@fujitsu.com 2020-07-14 11:26:32 RE: problem with RETURNING and update row movement