| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | "David E(dot) Wheeler" <david(at)justatheory(dot)com> |
| Cc: | Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: ABI Compliance Checker GSoC Project |
| Date: | 2025-09-12 15:37:32 |
| Message-ID: | 8720cb48-39c9-4c61-8f1c-ef9d51208b5c@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.09.25 16:52, David E. Wheeler wrote:
> On Sep 12, 2025, at 10:37, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
>> This was a change that was intentionally backpatched in a different way in order to preserve ABI compatibility. Compare commits 344662848ac on REL_18_STABLE and 0b934d3994f on REL_17_STABLE. So everything is in order. :)
>
> Excellent! But an example like this presumably helps make Tom’s case that each branch could have a file that suggests which commit to use as the base for comparison, so that in this example it could be set to 344662848ac and the failures would go away. As it is, they will persist until a new tag is added or one overrides the base in the build farm client config.
I don't think we need any ABI checking until there is a dot-0 release,
so I don't agree that a facility like that is needed. Just compare
against the previous release tag.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2025-09-12 15:46:25 | Re: PostgreSQL 18 GA press release draft |
| Previous Message | Tom Lane | 2025-09-12 15:08:51 | Re: plan shape work |