| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "PostgreSQL-development Hackers" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Document and/or remove unreachable code in tuptoaster.c from varvarlena patch |
| Date: | 2007-07-27 17:17:21 |
| Message-ID: | 871wetpxzy.fsf@oxford.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Sorry, meant to send the previous message to pgsql-patches.
Here's a version cut using cvs diff so it's usable with -p0
I added one more fixup. There was a silly test in toast_fetch_datum_slice()
which handled compressed datums. Returning a slice of a compressed datum is
nonsensical with toast since the resulting datum would be useless. I also
added an assertion in this function that the datum is external before we treat
it as a toast_pointer.
(Incidentally, I did eventually manage to construct a case to reach all the pfrees.)
| Attachment | Content-Type | Size |
|---|---|---|
| tuptoaster-fixup.patch.gz | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2007-07-27 18:09:52 | Re: [PATCHES] allow CSV quote in NULL |
| Previous Message | Andrew Dunstan | 2007-07-27 16:03:19 | Re: [PATCHES] allow CSV quote in NULL |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2007-07-27 18:09:52 | Re: [PATCHES] allow CSV quote in NULL |
| Previous Message | Erwin Brandstetter | 2007-07-27 16:17:19 | Obsolete bits in docs for SQL-GRANT |