Re: Should contrib modules install .h files?

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Should contrib modules install .h files?
Date: 2018-08-02 18:42:31
Message-ID: 871sbgaa18.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Andres" == Andres Freund <andres(at)anarazel(dot)de> writes:

Tom> There's also a question of whether we need to change anything in
Tom> contrib/ so that it plays by whatever rules we set. There's an
Tom> expectation that contrib modules should be buildable with PGXS,
Tom> so they need to follow the rules.

Andrew> ... that at least all of the *_plperl transform modules in
Andrew> contrib/ fail to build with USE_PGXS already (i.e. for as long
Andrew> as they have ever existed), because they rely on
Andrew> plperl_helpers.h which is never installed anywhere, and trying
Andrew> to get it via $(top_srcdir) obviously can't work in PGXS.

Andrew> Haven't tried the python ones yet.

>> And none of the plpython transforms can even parse their makefiles
>> with USE_PGXS, let alone build, because they have an "include"
>> directive pointing into src/pl/plpython.

Andres> FWIW, I'd be perfectly on board with just burying this policy.
Andres> Designating one contrib module (or something in
Andres> src/test/examples or such) as a PGXS example, and always
Andres> building it with pgxs seems like it'd do a much better job than
Andres> the current policy.

I suggest that modules that actually _can't_ build with PGXS should have
the PGXS logic removed from their makefiles (perhaps replaced with an
error). But for the rest, it's a convenience to be able to build single
modules using USE_PGXS without having to configure the whole source tree.

--
Andrew (irc:RhodiumToad)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-08-02 19:07:13 Re: BUG #15182: Canceling authentication due to timeout aka Denial of Service Attack
Previous Message Tom Lane 2018-08-02 18:31:38 Re: Should contrib modules install .h files?