Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: 2019-06-14 22:14:09
Message-ID: 871rzv4yes.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

>>>>> "Andrew" == Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>>> This isn't good enough, because it still picks "UCT" on a system
>>> with no /etc/localtime and no TZ variable. Testing on HEAD as of
>>> 3da73d683 (on FreeBSD, but it'll be the same anywhere else):

Tom> [ shrug... ] Too bad. I doubt that that's a common situation anyway.

Andrew> I'm also reminded that this applies also if the /etc/localtime
Andrew> file is a _copy_ of the UTC zonefile rather than a symlink,
Andrew> which is possibly even more common.

And testing shows that if you select "UTC" when installing FreeBSD, you
indeed get /etc/localtime as a copy not a symlink, and I've confirmed
that initdb picks "UCT" in that case.

So here is my current proposed fix.

--
Andrew (irc:RhodiumToad)

Attachment Content-Type Size
utcpref.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-14 22:27:12 pgsql: Add pg_dumpall --rows-per-insert
Previous Message Alvaro Herrera 2019-06-14 22:07:01 pgsql: Tweak libpq's PQhost, PQhostaddr, and psql's \connect

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-06-14 22:27:29 Re: pg_dump multi VALUES INSERT
Previous Message Bruce Momjian 2019-06-14 22:09:40 Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS)