Re: LWLockAcquire and LockBuffer mode argument

From: ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker )
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers\(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: LWLockAcquire and LockBuffer mode argument
Date: 2020-08-26 11:47:06
Message-ID: 871rjthbnp.fsf@wibble.ilmari.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:

> Hi,
>
> On 2020-08-25 13:59:35 -0400, Robert Haas wrote:
>
>> However, if we do it all in a backward-compatible way as you propose,
>> then we're likely to keep reintroducing code that does it the old way
>> for a really long time. I'm not sure that actually makes a lot of
>> sense. It might be better to just bite the bullet and make a hard
>> break.
>
> It seems easy enough to slap a compiler "enforced" deprecation warning
> on the new compat version, in master only. Seems unnecessary to make
> life immediately harder for extensions authors desiring cross-version
> compatibility.

Would it be possible to make the compat versions only available when
building extensions, but not to core code?

In Perl we do that a lot, using #ifndef PERL_CORE.

- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-08-26 12:08:51 Re: More tests with USING INDEX replident and dropped indexes
Previous Message Ashutosh Sharma 2020-08-26 11:36:09 Re: recovering from "found xmin ... from before relfrozenxid ..."