| From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kasahara Tatsuhito <kasahara(dot)tatsuhito(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Small and unaffected typo in pg_logical_slot_get_changes_guts() |
| Date: | 2022-02-17 11:33:55 |
| Message-ID: | 871r01g21o.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Feb 16, 2022 at 01:25:09PM +0900, Kasahara Tatsuhito wrote:
>> Remove all references to tuplestore_donestoring() except for the header.
>
> Looks fine, thanks. This has no impact on Melanie's patch posted on
> [1], so applied after tweaking the comment in tuplestore.h.
Would it be possible to make that macro only defined when building
extensions, but not when building Postgres itself? For example, Perl
has a PERL_CORE macro that's only defined when building Perl itself, but
not when building CPAN modules, and backwards-compatibility macros and
functions are guarded by `#ifndef PERL_CORE`.
- ilmari
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-02-17 12:02:23 | Re: [PATCH] Fix out-of-bouds access (src/common/wchar.c) |
| Previous Message | Amit Kapila | 2022-02-17 11:23:38 | Re: logical replication empty transactions |