Re: refactoring basebackup.c (zstd workers)

From: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Abhijit Menon-Sen <ams(at)toroid(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Subject: Re: refactoring basebackup.c (zstd workers)
Date: 2022-03-21 18:41:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:

> On Mon, Mar 21, 2022 at 2:22 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>> + * during parsing, and will otherwise contain a an appropriate error message.
> OK, thanks. v4 attached.

I haven't read the whole patch, but I noticed an omission in the
documentation changes:

> diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
> index 9178c779ba..00c593f1af 100644
> --- a/doc/src/sgml/protocol.sgml
> +++ b/doc/src/sgml/protocol.sgml
> @@ -2731,14 +2731,24 @@ The commands accepted in replication mode are:
> <varlistentry>
> - <term><literal>COMPRESSION_LEVEL</literal> <replaceable>level</replaceable></term>
> + <term><literal>COMPRESSION_DETAIL</literal> <replaceable>detail</replaceable></term>
> <listitem>
> <para>
> Specifies the compression level to be used.

This is no longer the accurate. How about something like like "Specifies
details of the chosen compression method"?

- ilmari

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-21 18:43:52 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message Peter Eisentraut 2022-03-21 18:40:22 Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)