From: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tristan Partin <tristan(at)neon(dot)tech>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Missing dep on Catalog.pm in meson rules |
Date: | 2023-06-16 22:10:26 |
Message-ID: | 871qibrrcd.fsf@wibble.ilmari.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> Hi,
>
> On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote:
>> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You
>> can only get at %INC by loading the module, which in many cases will have
>> side effects.
>
> I was envisioning using %INC after the use/require block - I don't think our
> scripts load additional modules after that point?
I was thinking of a module for writing depfile entries that would append
`values %INC` to the list of source files for each target specified by
the script.
>> And then you would also need to filter out things loaded that
>> are not our artefacts (e.g. Catalog.pm loads File::Compare).
>
> I don't think we would need to filter the output. This would just be for a
> build dependency file. I don't see a problem with rerunning genbki.pl et al after
> somebody updates File::Compare?
As long as mason doesn't object to dep files outside the source tree.
Otherwise, and option would be to pass in @SOURCE_ROOT@ and only include
`grep /^\Q$source_root\E\b/, values %INC` in the depfile.
> Greetings,
>
> Andres Freund
- ilmari
From | Date | Subject | |
---|---|---|---|
Next Message | Tristan Partin | 2023-06-16 22:11:59 | Re: [PATCH] Missing dep on Catalog.pm in meson rules |
Previous Message | Tom Lane | 2023-06-16 22:10:06 | Re: Default client_connection_check_interval to 10s on supported systems |