Re: [COMMITTERS] pgsql: Add basic TAP test setup for pg_upgrade

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: [COMMITTERS] pgsql: Add basic TAP test setup for pg_upgrade
Date: 2017-09-20 22:48:48
Message-ID: 8718090d-b6c0-3def-f66a-8508a6f74d3e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 9/20/17 12:18, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Add basic TAP test setup for pg_upgrade
>> The plan is to convert the current pg_upgrade test to the TAP
>> framework. This commit just puts a basic TAP test in place so that we
>> can see how the build farm behaves, since the build farm client has some
>> special knowledge of the pg_upgrade tests.
>
> I hope you're not planning to leave it like this very long. The
> pg_upgrade test is already one of the longest steps in the buildfarm
> runs, and now we're doing it twice.

Oh I see what is happening now. The buildfarm code looks for "t"
directories and runs tests there, and is at the same time hardcoded to
run check in the pg_upgrade directory.

So this will apparently require a buildfarm client code update after all.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2017-09-21 03:42:31 pgsql: Associate partitioning information with each RelOptInfo.
Previous Message Tom Lane 2017-09-20 17:52:43 pgsql: Improve dubious memory management in pg_newlocale_from_collation

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2017-09-20 22:49:10 Re: Windows warnings from VS 2017
Previous Message Daniel Gustafsson 2017-09-20 22:46:30 Re: PoC: full merge join on comparison clause