Re: Adding a stored generated column without long-lived locks

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: Alberto Piai <alberto(dot)piai(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Re: Adding a stored generated column without long-lived locks
Date: 2026-08-25 08:46:30
Message-ID: 86a9336dc25d9a085916ad247a5791dc53d2ab13.camel@cybertec.at
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2026-08-24 at 22:03 +0200, Alberto Piai wrote:
> > I was wondering about this hint:
> >
> >    Use this command on the root table/partition without ONLY.
> >
> > You can never turn a column of a partition into a generated column, right?
> > How about
> >
> >    Use the command on the partition root without specifying ONLY.
>
> Since this is also taking care of classic inheritance, it seems strange
> to only mention partitions. But I see that this way it's confusing (and
> I do concede that partitioning might be the more widely used of the two)
> so I switched it around to "on the root partition/table without
> specifying ONLY". Does that make more sense?

My problem is that there is no "root partition".

Perhaps

Use the command on the partitioning or inheritance root without specifying ONLY.

> > This detail message is longer than 80 characters:
> >
> >    Converting a column to a stored generated column can only be done on the whole hierarchy at once.
> >
> > How about
> >
> >    Converting only part of a partitioning/inheritance hierarchy is not supported.
>
> Much better, fixed.

I am having second thoughts about the slash.
Perhaps it would be better to use "or" instead.

Yours,
Laurenz Albe

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-08-25 08:49:39 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Hayato Kuroda (Fujitsu) 2026-08-25 08:46:13 RE: Patch for migration of the pg_commit_ts directory