Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: masao(dot)fujii(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date: 2026-06-18 03:05:58
Message-ID: 86F6E546-93AA-4B1C-9258-0B2BAB745881@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Jun 18, 2026, at 10:44, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>
> Hi,
>
>> Thanks for working on this!
>>
>> I have a couple of comments.
>>
>> When executing a non-existent function with IGNORE NULLS, for example,
>>
>> SELECT no_such_func() IGNORE NULLS;
>>
>> previously we got:
>>
>> ERROR: function no_such_func() does not exist
>>
>> but now we get:
>>
>> ERROR: only window functions accept RESPECT/IGNORE NULLS
>>
>> Isn't the previous error more helpful in this case? It makes me wonder
>> whether the IGNORE NULLS check is being performed too early. Perhaps
>> it would be better to move the check to other place.
>
> Agreed. BTW, if the check is moved there, it might be better to
> change the error message according to the surroundings. The pattern is
> "... specified, but %s is not a ..."
>
> errmsg("OVER specified, but %s is not a window function nor an aggregate function",
>
> So the message could be changed to something like:
>
> errmsg("RESPECT/IGNORE NULLS is specified, but %s is not a window function"),
>

Yes, this is also my only comment for the patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-06-18 03:19:53 Re: Fix race in ReplicationSlotRelease for ephemeral slots
Previous Message Fujii Masao 2026-06-18 03:03:42 Re: Rename EXISTS-to-ANY converted subplan to exists_to_any