From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de> |
Subject: | Re: Online enabling of checksums |
Date: | 2018-03-01 01:13:22 |
Message-ID: | 868781F5-29C3-4FB8-8243-03C47E60B2A8@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 01 Mar 2018, at 05:07, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> On 02/28/2018 08:42 PM, Alvaro Herrera wrote:
>> I noticed that pg_verify_checksum takes an "-o oid" argument to only
>> check the relation with that OID; but that's wrong, because the number
>> is a relfilenode, not an OID (since it's compared to the on-disk file
>> name). I would suggest changing everything to clarify that it's a
>> pg_class.relfilenode value, otherwise it's going to be very confusing.
>> Maybe use "-f filenode" if -f is available?
>
> I'd argue this is merely a mistake in the --help text.
Agreed, the --help text isn’t really clear in this case and should be updated
to say something along the lines of:
printf(_(" -o relfilenode check only relation with specified relfilenode\n"));
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2018-03-01 01:14:16 | Re: RFC: Add 'taint' field to pg_control. |
Previous Message | Craig Ringer | 2018-03-01 01:12:18 | Re: RFC: Add 'taint' field to pg_control. |