| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench - use pg logging capabilities |
| Date: | 2020-01-08 14:31:46 |
| Message-ID: | 86766a97-0107-168c-e932-6d083347c5e6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-01-08 15:12, Michael Paquier wrote:
> On Wed, Jan 08, 2020 at 02:27:46PM +0100, Peter Eisentraut wrote:
>> Committed.
>
> That was fast.
>
> - if (debug)
> + if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
> {
> I am surprised that you kept this one,
I'm not happy about it, but it seems OK for now. We can continue to
improve here.
> while syntax_error() has been
> changed in a more modular way.
I don't follow what you mean by that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2020-01-08 14:38:25 | src/test/recovery regression failure on bionic |
| Previous Message | Michael Paquier | 2020-01-08 14:12:24 | Re: pgbench - use pg logging capabilities |