Re: pglz performance

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Gasper Zejn <zejn(at)owca(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pglz performance
Date: 2019-11-27 18:27:49
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> 27 нояб. 2019 г., в 20:28, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> написал(а):
>>> 6) I'm pretty sure the comment in the 'while (off < len)' branch will be
>>> badly mangled by pgindent.
>> I think I can just write it without line limit and then run pgindent.
>> Will try to do it this evening. Also, I will try to write more about
>> memmove.
Well, yes, I could not make pgindent format some parts of that comment, gave up and left only simple text.
>>> 7) The last change moving "copy" to the next line seems unnecessary.
>> Oh, looks like I had been rewording this comment, and eventually came
>> to the same text..Yes, this change is absolutely unnecessary.
>> Thanks!
> Good. I'll wait for an updated version of the patch and then try to get
> it pushed by the end of the CF.

PFA v5.

Best regards, Andrey Borodin.

Attachment Content-Type Size
v5-0001-Use-memcpy-in-pglz-decompression.patch application/octet-stream 3.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-11-27 18:41:59 Re: pglz performance
Previous Message Mahendra Singh 2019-11-27 18:20:57 Re: [HACKERS] Block level parallel vacuum