Re: Typing Records

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typing Records
Date: 2010-08-24 16:27:20
Message-ID: 865.1282667240@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Aug 24, 2010 at 11:32 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I think it wouldn't take too much code to defend against this in
>> transformArrayExpr, but I'm a tad worried about whether there are
>> similar cases elsewhere. The generic problem is that we suppose that
>> different values are compatible if they have the same type OID, but
>> for RECORD types that's really not true.

> We've argued about this before: it's not really true for array types
> either.

Yeah, I'm starting to feel that the typmod hack for this is just not
good enough. However ...

> Nevertheless, there's not much hope of better than a localized fix for
> this particular bug.

This is a crash in released branches, so we have to have a
back-patchable fix. Anything that gets out from under the typmod issue
isn't going to be back-patchable.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Hunsaker 2010-08-24 16:28:56 Re: Unable to drop role
Previous Message Tom Lane 2010-08-24 16:06:34 Re: EXPLAIN doesn't show the actual function expression for FunctionScan