| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments |
| Date: | 2026-05-12 19:27:17 |
| Message-ID: | 86431.1778614037@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Aleksander Alekseev <aleksander(at)tigerdata(dot)com> writes:
>>> (Not that I understand what this is trying to tell me, mind)
>> Me either :-(
> I *think* maybe I was able to decipher it. PFA the patch.
Yeah, that seems like a plausible reconstruction of the logic.
I went ahead and pushed it.
Attached are the proposed pgindent change (same as before),
the additional manual corrections we've discussed needing,
and then the results of running the new pgindent after.
This looks pretty ready-to-go to me.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-pgindent-improve-formatting-of-multiline-comments.patch | text/x-diff | 3.1 KB |
| v8-manual-corrections.patch.nocfbot | text/x-diff | 22.4 KB |
| v8-auto-corrections.patch.nocfbot | text/x-diff | 172.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2026-05-12 20:12:54 | Re: [PATCH] libpq: try all addresses for a host before moving to next on target_session_attrs mismatch |
| Previous Message | Paul A Jungwirth | 2026-05-12 19:26:01 | Re: FOR PORTION OF does not recompute GENERATED STORED columns that depend on the range column |