Re: pgsql: Disable installcheck tests for test_session_hooks

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Disable installcheck tests for test_session_hooks
Date: 2017-11-16 16:21:11
Message-ID: 86100145-c471-b1f6-4c56-edd247ce43ac@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 11/16/2017 09:14 AM, Ashutosh Sharma wrote:
>>
>> Just sending an updated patch to cope with the fact that this module
>> does not need to define the EXTENSION and DATA fields, and does not
>> need a sql and a control file..
> While running make check with 'session_hook_makefile_v2.patch'
> applied, i could see the background worker (logical replication
> process) getting aborted due to assertion failure. Here are the logs
> observed in 'logs/postmaster.log' file.
>
> 2017-11-16 19:06:21.748 IST [65382] LOG: checkpoint complete: wrote 3
> buffers (0.0%); 0 WAL file(s) added, 0 removed, 0 recycled;
> write=0.000 s, sync=0.000 s, total=0.001 s; sync files=0,
> longest=0.000 s, average=0.000 s; distance=1 kB, estimate=1 kB
> 2017-11-16 19:06:21.869 IST [65382] LOG: checkpoint starting:
> immediate force wait
> 2017-11-16 19:06:21.870 IST [65382] LOG: checkpoint complete: wrote 0
> buffers (0.0%); 0 WAL file(s) added, 0 removed, 0 recycled;
> write=0.000 s, sync=0.000 s, total=0.000 s; sync files=0,
> longest=0.000 s, average=0.000 s; distance=0 kB, estimate=1 kB
> 2017-11-16 19:06:22.059 IST [65378] LOG: received fast shutdown request
> 2017-11-16 19:06:22.059 IST [65378] LOG: aborting any active transactions
> TRAP: BadState("!(((bool) ((CurrentUserId) != ((Oid) 0))))", File:
> "miscinit.c", Line: 286)
> 2017-11-16 19:06:22.090 IST [65378] LOG: background worker "logical
> replication launcher" (PID 65387) exited with exit code 1
> 2017-11-16 19:06:22.337 IST [65378] LOG: autovacuum launcher process
> (PID 65385) was terminated by signal 6: Aborted
> 2017-11-16 19:06:22.337 IST [65378] LOG: terminating any other active
> server processes
>

Ugh. I'm just going to revert the whole thing for now until we sort out
all the issues. 

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2017-11-16 16:40:16 pgsql: Back out the session_start and session_end hooks feature.
Previous Message Tom Lane 2017-11-16 16:17:03 pgsql: Fix bogus logic for checking data dirs' versions within pg_upgra

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-11-16 16:37:05 _WINSOCK_DEPRECATED_NO_WARNINGS
Previous Message Tom Lane 2017-11-16 16:20:02 Re: [HACKERS] A weird bit in pg_upgrade/exec.c