| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Muhammad Usama <m(dot)usama(at)gmail(dot)com> |
| Subject: | RE: A new function to wait for the backend exit after termination |
| Date: | 2020-12-03 02:21:51 |
| Message-ID: | 85e5241ce9724b5ca5fbe02f3b05a929@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > + ereport(WARNING,
> > + (errmsg("could not wait for the termination of the
> backend with PID %d within %ld milliseconds",
> > + pid, timeout)));
>
> > The code use %ld to print int64 type.
> > How about use INT64_FORMAT, which looks more appropriate.
>
> This is a translatable message, so INT64_FORMAT is no good -- we need
> something that is the same across platforms. The current project standard
> for this problem is to use "%lld" and explicitly cast the argument to long
> long int to match that.
Thank you for pointing out that,
And sorry for did not think of it.
Yes, we can use %lld, (long long int) timeout.
Best regards,
houzj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2020-12-03 02:27:28 | Re: Deprecate custom encoding conversions |
| Previous Message | Michael Paquier | 2020-12-03 02:03:49 | Renaming cryptohashes.c to cryptohashfuncs.c |