| From: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: removing global variable ThisTimeLineID |
| Date: | 2021-11-23 09:36:16 |
| Message-ID: | 85cd9f1c-b8e9-ea30-4df2-33ad12bfd2fc@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 11/8/21 6:49 PM, Robert Haas wrote:
> On Mon, Nov 8, 2021 at 8:27 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Well I went through and it seems to be OK: all the existing callers of
> that function first verify that we're not in recovery. The patch to
> make logical decoding work in standby mode might change that,
Indeed, I think the logical decoding on standby patch just needs to
change the Assert in GetWALInsertionTimeLine() to check
SharedRecoveryState is RECOVERY_STATE_DONE or RECOVERY_STATE_ARCHIVE.
Would that make sense from your point of view to add the check on
RECOVERY_STATE_ARCHIVE or do you think it would need to be more
"sophisticated"?
Thanks
Bertrand
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-11-23 10:13:57 | Re: WIP: WAL prefetch (another approach) |
| Previous Message | Daniel Gustafsson | 2021-11-23 09:17:23 | Re: psql - add SHOW_ALL_RESULTS option |