Re: Fix ISSN output truncation when the issue code is nonzero

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Jonah Shafran <jonahshafran(at)gmail(dot)com>
Subject: Re: Fix ISSN output truncation when the issue code is nonzero
Date: 2026-11-19 07:39:21
Message-ID: 85AC7054-7C4B-47B1-8BC0-3E972D0D34CD@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Nov 19, 2026, at 15:12, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
>
> Hi Chao
>
> On 19/11/2026 01:24, Chao Li wrote:
>> While debugging this patch, I noticed that the input isn has already been hyphenated, and ean2ISSN() is a local static function that is only called by ean2string(). Actually, your new logic of returning directly relies on isn being hyphenated. So I don't think we need to dehyphenate isn. Instead, we can just compare:
>> ```
>> if (strncmp(isn + 13, "00", 2) != 0)
>> return;
>> ```
>
> Good catch! dehyphenate is indeed superfluous here.
> v2 attached removes the function call and the digits buffer.
>
> Thanks!
>
> Best, Jim
>
> <v2-0001-Fix-ISSN-output-truncation-when-the-issue-code-is.patch>

Thanks for updating the patch. V2 looks good to me.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-11-19 07:39:42 Re: Detect mismatched subscription and replication slot properties
Previous Message Chao Li 2026-11-19 07:35:07 Re: Use an index scan in RemoveSubscriptionRel()