Re: thinko in convertToJsonb()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Mark Dilger <mark(at)port25(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: thinko in convertToJsonb()
Date: 2014-12-11 00:07:49
Message-ID: 8585.1418256469@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Tue, Dec 9, 2014 at 11:11 AM, Mark Dilger <mark(at)port25(dot)com> wrote:
>> Perhaps the code really meant to say:
>> reserveFromBuffer(&buffer, VARHDRSZ)

> Good catch! The code is indeed incorrect. Attached is a one-line patch
> addressing that, I guess someone is going to pick up that sooner or
> later.

Pushed, thanks!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2014-12-11 00:25:45 Re: On partitioning
Previous Message Robert Haas 2014-12-10 23:46:41 Re: advance local xmin more aggressively