| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query |
| Date: | 2018-07-06 20:56:22 |
| Message-ID: | 8551641530910582@myt5-9da6df248f4a.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
06.07.2018, 22:35, "Robert Haas" <robertmhaas(at)gmail(dot)com>:
> On Fri, Jul 6, 2018 at 1:26 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> Hmm... so pg_stat_statements_reset() is allowed to be executed by
>> pg_read_all_stats role while other stats reset functions like
>> pg_stat_reset() can be executed only by superusers. Which looks
>> strange and inconsistent to me.
>
> Yeah, why would a pg_READ_all_stats role let you change stuff?
+1, personally i was surprised first time. But I thought that it was discussed before committing version 1.5
I read original thread [1] and, as far i see, pg_stat_statements_reset change was not discussed.
Let's remove this grant?
Or grant to pg_monitor role instead of pg_read_all_stats?
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-07-06 21:08:02 | Re: Let's remove DSM_IMPL_NONE. |
| Previous Message | Peter Eisentraut | 2018-07-06 20:52:14 | Re: [PATCH] Use access() to check file existence in GetNewRelFileNode(). |