| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Swirl Smog Dowry <swirl-smog-dowry(at)duck(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_get_viewdef() produces non-round-trippable SQL for views with USING join on mismatched integer types |
| Date: | 2026-02-27 15:21:43 |
| Message-ID: | 852982.1772205703@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> I am on the fence about whether this fix is safe to back-patch to v18.
I don't think we have a lot of choice. The cases where it makes a
difference are pretty broken. Fortunately, I think these cases
are rare. JOIN USING combining two different-type columns has got
to be an edge-case usage, and I think it likely doesn't matter much
in other cases.
> However, this fix will only apply to newly created views. Users who
> have existing views affected by this bug will have to recreate them
> after upgrading to get the corrected pg_get_viewdef output.
Yeah :-(. What's really annoying is that probably people will not
notice until they try to upgrade to v19, and by then recreating
the view correctly might be difficult. But I'm not seeing a way
to smooth their path.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-02-27 18:08:36 | Re: pg_get_viewdef() produces non-round-trippable SQL for views with USING join on mismatched integer types |
| Previous Message | Agnieszka Chodkowska-Gyurics | 2026-02-27 14:50:27 | Re: BUG #19420: Zombie FK exists after partition is detached. |