Re: pgsql: pg_upgrade: Check version of target cluster binaries

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: Check version of target cluster binaries
Date: 2021-03-04 08:32:23
Message-ID: 851B64C2-C162-4856-9391-3AA15196E4CE@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 4 Mar 2021, at 08:24, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:

> I think the attached would be a sensible fix.

That's pretty much what I ended up with as well.

I was first looking at checking the version of the binary against the
major_version_str in ClusterInfo by passing down cluster instead, but that
turns into chicken-and-egg since we don't set the extracted version until we've
checked that pg_ctl exists and works.

Thanks!

--
Daniel Gustafsson https://vmware.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2021-03-04 08:59:16 pgsql: Remove server and libpq support for old FE/BE protocol version 2
Previous Message Peter Eisentraut 2021-03-04 07:24:07 Re: pgsql: pg_upgrade: Check version of target cluster binaries