Re: beta3 & the open items list

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Jun 20, 2010 at 5:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> https://commitfest.postgresql.org/action/patch_view?id=281

> +1 for applying something along these lines, but we'll also need to
> update walreceiver to actually use one or more of these new
> parameters.

Right, but the libpq-level support has to come first.

> On a quick read, I think I see a problem with this: if a parameter is
> specified with a non-zero value and there is no OS support available
> for that parameter, it's an error. Presumably, for our purposes here,
> we'd prefer to simply ignore any parameters for which OS support is
> not available. Given the nature of these parameters, one might argue
> that's a more useful behavior in general.

> Also, what about Windows?

Well, of course that patch hasn't been reviewed yet ... but shouldn't we
just be copying the existing server-side behavior, as to both points?

regards, tom lane