Wrong comment in tuptable.h

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Wrong comment in tuptable.h
Date: 2020-12-27 02:00:49
Message-ID: 84af28311995d6b3f584b254bff7e8664124d7c1.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

/*
* Return a copy of heap tuple representing the contents of the slot.
The
* copy needs to be palloc'd in the current memory context. The slot
* itself is expected to remain unaffected. It is *not* expected to
have
* meaningful "system columns" in the copy. The copy is not be
"owned" by
* the slot i.e. the caller has to take responsibility to free memory
* consumed by the slot.
*/
HeapTuple (*copy_heap_tuple) (TupleTableSlot *slot);

But acquire_sample_rows() calls ExecCopySlotHeapTuple(), and then
subsequently sorts the rows by TID. Is acquire_sample_rows() doing
something it shouldn't, or is the comment mistaken?

Regards,
Jeff Davis

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-12-27 03:43:14 Re: Wrong comment in tuptable.h
Previous Message Michael Paquier 2020-12-27 01:11:17 Re: pgsql: Add pg_alterckey utility to change the cluster key