| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Virender Singla <virender(dot)cse(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Aniket Jha <aniketkumarj(at)gmail(dot)com> |
| Subject: | Re: Major Version Upgrade failure due to orphan roles entries in catalog |
| Date: | 2026-03-02 16:17:03 |
| Message-ID: | 846352.1772468223@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Feb 27, 2026 at 4:52 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Fair ... do you have a suggestion for less confusing names?
>> I considered naming the new variable "dump_this_grantor", but thought
>> it was longer without being more helpful ... but maybe you disagree.
> Personally, I'd find the extra verbosity helpful, but I don't care
> that much if you see it otherwise.
If you think that's better, I'm happy to make it so. An author is
seldom the best judge of readability of his code.
Pushed like that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-03-02 19:15:51 | Re: basic_archive lost archive_directory |
| Previous Message | Robert Haas | 2026-03-02 14:19:29 | Re: Major Version Upgrade failure due to orphan roles entries in catalog |