| From: | Ian Barwick <ian(dot)barwick(at)2ndquadrant(dot)com> |
|---|---|
| To: | Sergei Kornilov <sk(at)zsrv(dot)org>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ ) |
| Date: | 2019-07-19 13:40:42 |
| Message-ID: | 845b1b4e-e7a0-3634-6514-769767fbd41b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/19/19 7:45 PM, Sergei Kornilov wrote:
> Hi
>
> Oh. Replication slot name currently can contains only a-z0-9_ characters. So
> we can not actually write such recovery.conf, pg_basebackup will stop
> before. But perform escape_quotes on string and not use result - error anyway.
Good point, it does actually fail with an error if an impossible slot name
is provided, so the escaping is superfluous anyway.
I'll take another look at it later as it's not exactly critical, just stuck
out when I was passing through the code.
Regards
Ian Barwick
--
Ian Barwick https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-07-19 13:43:54 | Re: [HACKERS] advanced partition matching algorithm for partition-wise join |
| Previous Message | Mike Palmiotto | 2019-07-19 13:37:45 | Re: sepgsql seems rather thoroughly broken on Fedora 30 |