Re: pgstattuple extension for indexes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, ishii(at)sraoss(dot)co(dot)jp
Subject: Re: pgstattuple extension for indexes
Date: 2006-09-04 02:13:41
Message-ID: 8453.1157336021@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp> writes:
> Tom Lane wrote:
>> pgstatindex.c: In function 'bt_page_items':
>> pgstatindex.c:564: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

> I guess my '%d' should be '%zd', right?

No, that sounds even less portable :-(

Given the expected range of IndexTupleSize(), it seems sufficient to
cast its result to int and then use %d formatting. I've done that
in the latest commit.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Browne 2006-09-04 02:15:19 On Certification (was Re: [GENERAL] Thought provoking piece on NetBSD)
Previous Message Bruce Momjian 2006-09-04 02:11:40 Re: Getting a move on for 8.2 beta

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-09-04 02:21:11 Re: [HACKERS] Interval month, week -> day
Previous Message Andrew Dunstan 2006-09-04 02:09:08 Re: [HACKERS] python / 7.4 / FC5 / x86_64