Re: Fix pg_dump dependency on postgres.h

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_dump dependency on postgres.h
Date: 2008-03-27 04:03:05
Message-ID: 845.1206590585@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> Thank your for Your and Alvaro's comments. I attached updated patch
> version only with YYSTYPE definition.

Applied with minor revisions. I fixed pg_conversion.h as well; the only
remaining special inclusions in the catalog header files are of
pg_list.h. For the moment that header doesn't seem to be a problem
for client-side code to include, but someday we may want to do more
cleanup here.

The immediate remaining problem is that pg_resetxlog.c still includes
a bunch of backend-only headers, which as far as I understand still
blocks your build requirements. I poked at this a little bit, but
didn't see any easy solution ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-03-27 04:13:42 Re: [DOCS] pg_total_relation_size() and CHECKPOINT
Previous Message Andrew Dunstan 2008-03-27 03:25:51 Re: [DOCS] pg_total_relation_size() and CHECKPOINT

Browse pgsql-patches by date

  From Date Subject
Next Message Gevik Babakhani 2008-03-27 09:25:24 Re: V1.1 patch for TODO Item: SQL-language reference parameters by name.
Previous Message Joshua D. Drake 2008-03-26 22:38:28 Re: Script binaries renaming