| From: | Bernd Helmle <mailings(at)oopsware(dot)de> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Provide support for trailing commas |
| Date: | 2026-01-08 19:24:32 |
| Message-ID: | 844b43b7adca538fe22a0234f74d39f58fea5528.camel@oopsware.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Am Donnerstag, dem 08.01.2026 um 10:53 +1300 schrieb David Rowley:
> Personally, I don't want this feature. I'd rather receive an error
> message when I make silly mistakes in code that I write. If I have
> code to dynamically build an SQL statement and I have a bug that
> causes a variable that stores a column name to sometimes be an empty
> string, with your patch, I'll get an error message in all cases
> unless
> the column's position is last. I want the error at all times, not
> sometimes.
This is exactly what i initially thought when reading through this
thread. Yes, people have their arguments, but it also feels like a big
hammer for a rather small issue, looking on what technical implications
are discussed and might hit us.
In other words, I never got a single complaint from people using
PostgreSQL in the last two decades for not allowing trailing commas in
our parser. And to be honest, i never thought about this before Greg's
proposal ...
--
Thanks,
Bernd
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-01-08 19:34:28 | Re: improve performance of pg_dump with many sequences |
| Previous Message | Robert Haas | 2026-01-08 19:23:48 | Re: pg_plan_advice |