Re: Modernizing SQL functions' result type coercions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Petr Fedorov <petr(dot)fedorov(at)phystech(dot)edu>
Subject: Re: Modernizing SQL functions' result type coercions
Date: 2020-01-08 15:22:55
Message-ID: 8442.1578496975@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> In init_sql_fcache(), one comment says that the junkfilter is
> responsible for injecting NULLs for dropped columns, and a later comment
> says that the junk filter gets "rid of any dropped columns". That seems
> contradictory; which is it? Or does "get rid of" mean "set to NULL"?

Yeah, the second comment is sloppily worded; the first one is more
accurate.

> Other than that, looks good to me.

Thanks for reviewing! I'll fix that comment and push.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-01-08 15:58:09 Re: weird libpq GSSAPI comment
Previous Message Heikki Linnakangas 2020-01-08 15:06:46 Re: Modernizing SQL functions' result type coercions