| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com> |
| Subject: | Re: Why do we have perl and sed versions of Gen_dummy_probes? |
| Date: | 2021-05-11 14:52:22 |
| Message-ID: | 842619.1620744742@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 5/10/21 12:07 PM, Tom Lane wrote:
>> I don't think this is good practice; it implies that any
>> accidental corruption of the commentary would be carried
>> forward. I think we should be extracting the commentary
>> from Gen_dummy_probes.sed.
> I don't know how likely accidental corruption is, but OK, let's not make
> the next generation dependent on the current generation of the file. The
> simplest way around that seems to me to cache the perl prolog, as in the
> attached patch Is that more to your liking? I also adjusted it so we
> pick up the first line of code from s2p rather than from the prolog,
> which is now just comments and the #! line.
Works for me. One other thought --- do we care whether this works
in a VPATH build, and if so does it? The $< and $@ references should
be OK, but I'm betting you need $(srcdir)/Gen_dummy_probes.pl.prolog
or the like.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2021-05-11 15:02:08 | Re: Corrected documentation of data type for the logical replication message formats. |
| Previous Message | Bruce Momjian | 2021-05-11 14:48:11 | Re: PG 14 release notes, first draft |