From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | Jelte Fennema <postgres(at)jeltef(dot)nl>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Jesse Zhang <sbjesse(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: run pgindent on a regular basis / scripted manner |
Date: | 2023-04-26 13:27:05 |
Message-ID: | 841085.1682515625@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 24.04.23 16:14, Tom Lane wrote:
>> I certainly don't like its current behavior where adding/changing one
>> line can have side-effects on nearby lines. But we have a proposal
>> to clean that up, and I'm cautiously optimistic that it'll be better
>> in future. Did you have other specific concerns?
> I think the worst is how it handles multi-line data structures like
> $newnode->command_ok(
> [
> 'psql', '-X',
> '-v', 'ON_ERROR_STOP=1',
> '-c', $upcmds,
> '-d', $oldnode->connstr($updb),
> ],
> "ran version adaptation commands for database $updb");
Yeah, I agree, there is no case where that doesn't suck. I don't
mind it imposing specific placements of brackets and so on ---
that's very analogous to what pgindent will do. But it likes to
re-flow comma-separated lists, and generally manages to make a
complete logical hash of them when it does, as in your other
example:
> $node->command_fails_like(
> [
> 'pg_basebackup', '-D',
> "$tempdir/backup", '--compress',
> $cft->[0]
> ],
> qr/$cfail/,
> 'client ' . $cft->[2]);
Can we fix it to preserve the programmer's choices of line breaks
in comma-separated lists?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Giuseppe Broccolo | 2023-04-26 13:31:37 | Re: vector search support |
Previous Message | Aleksander Alekseev | 2023-04-26 13:00:08 | Re: [PATCH] Compression dictionaries for JSONB |