Re: need higher extra_float_digits value (3)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Keh-Cheng Chu <kehcheng(at)solar2(dot)Stanford(dot)EDU>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: need higher extra_float_digits value (3)
Date: 2009-09-09 22:04:29
Message-ID: 8398.1252533869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Keh-Cheng Chu <kehcheng(at)solar2(dot)Stanford(dot)EDU> writes:
> While 17 decimal digits are sufficient to guarantee the
> complete recovery of all 64-bit double values, some 32-bit
> reals actually require NINE significant figures.

Hm, annoying. Seems like we could do one of two things:

1. Increase the max extra_float_digits value to 3 and have pg_dump use
that.

2. Split extra_float_digits into two settings so that float4 and float8
can use different settings.

Offhand the only argument I can see for #2 is that #1 might bloat dump
files unnecessarily --- but it's not likely to be significant on a
percentage basis.

We'd also need to check the code to be sure it's leaving room for the
extra digit in all cases, though I doubt there's really any problem.

Comments?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Robert Haas 2009-09-10 01:18:50 Re: need higher extra_float_digits value (3)
Previous Message Tom Lane 2009-09-09 19:44:09 Re: BUG #5038: WAL file is pending deletion in pg_xlog folder, this interferes with WAL archiving.