Re: Adding REPACK [concurrently]

From: Antonin Houska <ah(at)cybertec(dot)at>
To: Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Adding REPACK [concurrently]
Date: 2026-03-02 17:23:30
Message-ID: 83637.1772472210@localhost
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Antonin Houska <ah(at)cybertec(dot)at> wrote:

> Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com> wrote:
> > ------------
> >
> > > attrs = palloc0_array(Datum, desc->natts);
> > > isnull = palloc0_array(bool, desc->natts);
> >
> > It looks like there is a memory leak with those arrays.
>
> I suppose you mean store_change(). Yes, I tried to free the individual chunks
> and forgot these. The next version uses a new, per-change memory context.

I realize now that I forgot to reset the context at the end of the
function. I'll fix that in the next version (which will probably be posted
rather soon).

--
Antonin Houska
Web: https://www.cybertec-postgresql.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-03-02 17:24:02 Re: Fix bug in multixact Oldest*MXactId initialization and access
Previous Message Melanie Plageman 2026-03-02 17:15:34 Re: Correcting freeze conflict horizon calculation