| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "andrew(at)dunslane(dot)net" <andrew(at)dunslane(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Enable SSL library detection via PQsslAttribute |
| Date: | 2022-02-23 23:20:52 |
| Message-ID: | 83541b1e7873f2adb862f7f3ec763fae30a731b5.camel@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2022-02-23 at 14:11 -0500, Andrew Dunstan wrote:
> On 2/23/22 13:38, Jacob Champion wrote:
> >
> > If this looks good, I'm not sure how best to test it in the regression
> > suite. I see that libpq has an installcheck recipe that compiles a test
> > executable for URI parsing; should I add a simple test alongside that?
>
> Create a TAP tests that calls a small client?
First stab in v2-0002. Though I see that Andres is overhauling the
tests in this folder today [1], so I'll need to watch that thread. :)
Thanks!
--Jacob
[1] https://www.postgresql.org/message-id/20220223203031.ezrd73ohvjgfksow%40alap3.anarazel.de
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Enable-SSL-library-detection-via-PQsslAttribute.patch | text/x-patch | 2.2 KB |
| v2-0002-WIP-add-regression-test-for-PQsslAttribute.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-02-23 23:21:36 | Re: convert libpq uri-regress tests to tap test |
| Previous Message | Tom Lane | 2022-02-23 23:15:07 | Re: libpq async duplicate error results |