Re: Fix casting away const in _bt_reorder_array_cmp

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix casting away const in _bt_reorder_array_cmp
Date: 2026-01-12 15:46:18
Message-ID: 8341ef2b-858b-4374-9e7e-cf7d803bd464@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 31.12.25 10:01, Bertrand Drouvot wrote:
> On Wed, Dec 31, 2025 at 03:51:55PM +0800, Chao Li wrote:
>> There have been several recent efforts to eliminate cast-away-const usages.
>> While reviewing another patch, I happened to notice one such occurrence, so
>> I’m posting a trivial patch to fix it.
>
> Thanks for the patch!
>
> This one is one that I choose to discard in [1] because this is just a thin
> wrapper. Not saying that keeping cast away const was a good thing but the idea
> was also to reduce the number of changes in the patch.

I have committed this one together with Bertrand's other changes.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2026-01-12 15:54:52 Re: WIP - xmlvalidate implementation from TODO list
Previous Message Peter Eisentraut 2026-01-12 15:44:19 Re: Don't cast away const where possible