| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Neha Khatri <nehakhatri5(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
| Cc: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: If subscription to foreign table valid ? |
| Date: | 2017-05-17 02:59:18 |
| Message-ID: | 831efb82-7a14-2b67-ee30-739d94adcc5d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5/14/17 23:55, Neha Khatri wrote:
> With this patch the error will be like this:
>
> logical replication target relation public.t is not a table
>
> But it is possible that the referred table is Foreign Table of
> Partitioned table (so actually the referred object is indeed a table).
> Would it make sense to specify in the message that the table is not a
> normal table or something in that line?
This is how we phrase the message in other places where we check the
relkind. We should keep that consistent.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2017-05-17 03:34:56 | Re: [POC] hash partitioning |
| Previous Message | Peter Eisentraut | 2017-05-17 02:58:21 | Re: If subscription to foreign table valid ? |