Re: "make installcheck" fails in src/test/recovery

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: "make installcheck" fails in src/test/recovery
Date: 2019-04-19 01:31:21
Message-ID: 831.1555637481@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> I am wondering if it would be better to just install automatically all
> the paths listed in EXTRA_INSTALL when invoking installcheck.

Absolutely not! In the first place, "make installcheck" is supposed to
test the installed tree, not editorialize upon what's in it; and in the
second place, you wouldn't necessarily have permissions to change that
tree.

If we think that depending on pageinspect is worthwhile here, the right
thing to do is just to fix the README to say that you need it. I'm
merely asking whether it's really worth the extra dependency.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-04-19 02:04:09 Re: ExecForceStoreMinimalTuple leaks memory like there's no tomorrow
Previous Message Michael Paquier 2019-04-19 00:46:13 Re: Pathological performance when inserting many NULLs into a unique index