Re: Replace offnum++ by OffsetNumberNext

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <fujii(dot)masao(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Replace offnum++ by OffsetNumberNext
Date: 2008-04-04 21:04:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Fujii Masao <fujii(dot)masao(at)oss(dot)ntt(dot)co(dot)jp> writes:
> This is the patch replace offnum++ by OffsetNumberNext.
> According to off.h, OffsetNumberNext is the macro prepared to
> disambiguate the different manipulations on OffsetNumbers.
> But, increment operator was used in some places instead of the macro.

I wonder if we shouldn't go the other way, ie, use ++ everywhere.
OffsetNumberNext seems like just useless obscurantism ...

regards, tom lane

In response to


Browse pgsql-patches by date

  From Date Subject
Next Message Pavel Stehule 2008-04-04 21:09:59 fixing sql generated features - plpgsql case statement
Previous Message Teodor Sigaev 2008-04-04 20:20:23 Partial match in GIN