Re: Split copy.c

From: Erikjan Rijkers <er(at)xs4all(dot)nl>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: Split copy.c
Date: 2020-11-03 08:46:36
Message-ID: 82dcd18c3e873b390a5b914d9d9b8059@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-11-03 08:38, Heikki Linnakangas wrote:

> [v3-0001-Split-copy.c-into-copyto.c-and-copyfrom.c.patch]
> [v3-0002-Split-copyfrom.c-further-into-copyfrom.c-and-copy.patch]

The patches apply ok, but I get these errors:

In file included from ../../../src/include/postgres.h:46,
from copyto.c:15:
copyto.c: In function ‘BeginCopyTo’:
copyto.c:477:11: error: ‘is_from’ undeclared (first use in this
function); did you mean ‘is_program’?
Assert(!is_from);
^~~~~~~
../../../src/include/c.h:790:9: note: in definition of macro ‘Assert’
if (!(condition)) \
^~~~~~~~~
copyto.c:477:11: note: each undeclared identifier is reported only once
for each function it appears in
Assert(!is_from);
^~~~~~~
../../../src/include/c.h:790:9: note: in definition of macro ‘Assert’
if (!(condition)) \
^~~~~~~~~

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-11-03 08:59:08 Re: Parallel copy
Previous Message Magnus Hagander 2020-11-03 08:31:20 Re: Online checksums verification in the backend