New option in pg_basebackup to exclude pg_log files during base backup

From: "Prabakaran, Vaishnavi" <vaishnavip(at)fast(dot)au(dot)fujitsu(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: New option in pg_basebackup to exclude pg_log files during base backup
Date: 2014-04-09 00:06:30
Message-ID: 82897A1301080E4B8E461DDAA0FFCF142A1B2660@SYD1216
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

Following the discussion in message id - CAHGQGwFFMOr4EcugWHZpAaPYQbsEKDg66VmJ1rveJ6Z-EgaqAg(at)mail(dot)gmail(dot)com<mailto:CAHGQGwFFMOr4EcugWHZpAaPYQbsEKDg66VmJ1rveJ6Z-EgaqAg(at)mail(dot)gmail(dot)com> , I have developed the patch which gives option to user to exclude pg_log directory contents in pg_basebackup.

[Current situation]
During pg_basebackup, all files in pg_log directory will be copied to new backup directory.

[Design]
- Added new non-mandatory option "-S/--skip-log-dir" to pg_basebackup .
- If "skip-log-dir" is specified in pg_basebackup command, then in basebackup, exclude copying log files from standard "pg_log" directory and any other directory specified in Log_directory guc variable. (Still empty folder "pg_log"/$Log_directory will be created)
- In case, pg_log/$Log_directory is symbolic link, then an empty folder will be created

[Advantage]
It gives an option to user to avoid copying of large log files if they doesn't wish to and hence can save memory space.

Attached the patch.

Thanks & Regards,
Vaishnavi
Fujitsu Australia

Attachment Content-Type Size
pgbasebackup_excludes_pglog_v1.patch application/octet-stream 8.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2014-04-09 00:55:47 Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Previous Message Peter Geoghegan 2014-04-08 23:10:11 Re: Default gin operator class of jsonb failing with index row size maximum reached