Re: Change ereport level for QueuePartitionConstraintValidation

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <langote_amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: Change ereport level for QueuePartitionConstraintValidation
Date: 2019-08-20 15:20:10
Message-ID: 8283171566314410@myt3-2475c4d2af83.qloud-c.yandex.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

> Sergei, can we enlist you to submit a patch for this? Namely reduce the
> log level to DEBUG1 and add a TAP test in src/test/modules/alter_table/
> that verifies that the message is or isn't emitted, as appropriate.

I created this patch.
I test message existence. Also I check message "verifying table" (generated on DEBUG1 from ATRewriteTable). So with manually damaged logic in NotNullImpliedByRelConstraints or ConstraintImpliedByRelConstraint "make check" may works but fails on new test during "make check-world". As we want.

regards, Sergei

Attachment Content-Type Size
0002_alter_table_tap_test.patch text/x-diff 12.9 KB
0001_lowering_partition_constraint_check_ereport_level.patch text/x-diff 7.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-08-20 15:43:41 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Stephen Frost 2019-08-20 15:04:57 Re: pg_upgrade fails with non-standard ACL